[Webkit-unassigned] [Bug 124474] [EFL] Implement download directory selector on Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124474





--- Comment #10 from Jongwoo Choi <jw0330.choi at samsung.com>  2013-11-21 16:18:50 PST ---
(In reply to comment #9)
> (From update of attachment 217515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217515&action=review
> 
> BTW, how can I see this directory picker ? Could you let me know an example ?
> 
> > Tools/MiniBrowser/efl/main.c:133
> > +    Browser_Window* parent;
> 
> Wrong * place.
> 
> > Tools/MiniBrowser/efl/main.c:190
> > +static void quit_event_loop(void *user_data, Evas_Object *obj, void *event_info);
> 
> Where is this function used ?
> 
> > Tools/MiniBrowser/efl/main.c:598
> > +
> 
> Unneeded line.
> 
> > Tools/MiniBrowser/efl/main.c:599
> > +static void on_directorypicker_parent_deletion(void *user_data, Evas *evas, Evas_Object *elm_window, void *event_info);
> 
> To be sync with other function, please use on_directory_picker_parent_deletion(...)
> 
> > Tools/MiniBrowser/efl/main.c:638
> > +            char unique_path[] = "downloaded-file.XXXXXX";
> 
> Can't we support new name if there is already "downloaded-file.XXXXXX" in /tmp ? For instance, if there is downloaded-file-1.XXX, next no name file will be saved as download-file-2.XXX.

Download picker, can be seen at the following address.
http://www.w3.org/TR/2000/REC-ATAG10-20000203/atag10.tgz

Filename consist with XXX(six or more'X') will be replaced unique file name  after mktemp(unique_path). For example, download-file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.