[Webkit-unassigned] [Bug 105784] Remove ENABLE_WORKERS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105784





--- Comment #26 from Joseph Pecoraro <joepeck at webkit.org>  2013-11-21 11:13:43 PST ---
(In reply to comment #24)
> (In reply to comment #22)
> > (From update of attachment 217293 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=217293&action=review
> > 
> > > Source/WebCore/inspector/InspectorWorkerAgent.cpp:158
> > >  void InspectorWorkerAgent::canInspectWorkers(ErrorString*, bool* result)
> > >  {
> > > -#if ENABLE(WORKERS)
> > >      *result = true;
> > > -#else
> > > -    *result = false;
> > > -#endif
> > >  }
> > 
> > Remove this function instead and clean the call sites.
> > 
> 
> It seems this is used by the Inspector UI, and can't be removed without modifying it. As I'm not familiar with the Inspector, CCing Joe and Timothy. What do you think about this? Is it reasonable removing canInspectWorkers?

No, please do not remove canInspectWorkers at this time.

This is part of the protocol (WebCore/inspector/protocol/Worker.json) and we would want to leave it in right now at least for protocol backwards compatibility. We can evaluate later if we should remove it ourselves, but at least for now please leave it in.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.