[Webkit-unassigned] [Bug 105784] Remove ENABLE_WORKERS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105784


Peter Molnar <pmolnar.u-szeged at partner.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org,
                   |                            |pmolnar.u-szeged at partner.sa
                   |                            |msung.com,
                   |                            |timothy at apple.com




--- Comment #24 from Peter Molnar <pmolnar.u-szeged at partner.samsung.com>  2013-11-21 06:12:57 PST ---
(In reply to comment #22)
> (From update of attachment 217293 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217293&action=review
> 
> > Source/WebCore/inspector/InspectorWorkerAgent.cpp:158
> >  void InspectorWorkerAgent::canInspectWorkers(ErrorString*, bool* result)
> >  {
> > -#if ENABLE(WORKERS)
> >      *result = true;
> > -#else
> > -    *result = false;
> > -#endif
> >  }
> 
> Remove this function instead and clean the call sites.
> 

It seems this is used by the Inspector UI, and can't be removed without modifying it. As I'm not familiar with the Inspector, CCing Joe and Timothy. What do you think about this? Is it reasonable removing canInspectWorkers?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.