[Webkit-unassigned] [Bug 124661] [GTK] Release compilation fails when defining "LOG_DISABLED=0"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124661





--- Comment #4 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-21 06:04:41 PST ---
(In reply to comment #2)
> (From update of attachment 217438 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217438&action=review
> 
> > Source/WebCore/html/HTMLTrackElement.cpp:36
> > +#if !LOG_DISABLED
> 
> The usage of the CString class inside this file is not behind any !LOG_DISABLED guard so I think you should not put the include behind it either, because if you do it so it would be because you know how that macro is being defined, and not based in the information you have by looking at this implementation file only.
> 
> So, even though calls to LOG() won't ever be translated to anything requiring CString if !LOG_DISABLED (and that's why it does not fail otherwise), I believe it's better to be consistent and just include CString normally, as it's done in other places (e.g. HTMLMediaElement.cpp)
...

Done.

Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.