[Webkit-unassigned] [Bug 124661] [GTK] Release compilation fails when defining "LOG_DISABLED=0"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124661


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217438|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-11-21 05:56:41 PST ---
(From update of attachment 217438)
View in context: https://bugs.webkit.org/attachment.cgi?id=217438&action=review

> Source/WebCore/html/HTMLTrackElement.cpp:36
> +#if !LOG_DISABLED

The usage of the CString class inside this file is not behind any !LOG_DISABLED guard so I think you should not put the include behind it either, because if you do it so it would be because you know how that macro is being defined, and not based in the information you have by looking at this implementation file only.

So, even though calls to LOG() won't ever be translated to anything requiring CString if !LOG_DISABLED (and that's why it does not fail otherwise), I believe it's better to be consistent and just include CString normally, as it's done in other places (e.g. HTMLMediaElement.cpp)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.