[Webkit-unassigned] [Bug 107606] EWS creates 0 byte sized log files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107606


László Langó <lango at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lango at inf.u-szeged.hu




--- Comment #4 from László Langó <lango at inf.u-szeged.hu>  2013-11-21 05:53:59 PST ---
(In reply to comment #3)
> (From update of attachment 216578 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216578&action=review
> 
> > Tools/ChangeLog:13
> > +
> > +        * Scripts/webkitpy/tool/bot/queueengine.py:
> > +        (QueueEngine.run):
> > +        (QueueEngine._open_work_log):
> > +        (QueueEngine._ensure_work_log_closed):
> > +        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
> > +        (AbstractEarlyWarningSystem.review_patch):
> 
> I'd like to see some description as to why this bug manifested and how you fixed it.
> There is a lot of code change here, and the correctness of code change is not self-evident.

There was a modification in r138264, that tried to make less log, because some of the messeges were duplicated. After this the EWS created the log file (with the same name as the bugID) but doesn't write anything into it, even if there were errors during the build. So i managed this. Now it will create the log file only if there is an error, and wont create if dont want to write anything to it.

The main problem was that, the ScriptError was not raised and the QueueEngine never get that. Now it gets the error and handles it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.