[Webkit-unassigned] [Bug 119436] [curl] Improve detecting and handling of SSL related errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 01:53:33 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=119436





--- Comment #37 from sipka at inf.u-szeged.hu  2013-11-21 01:52:06 PST ---
(In reply to comment #36)
> (From update of attachment 217468 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217468&action=review
> 
> > Source/WebCore/platform/network/curl/SSLHandle.cpp:46
> > +    HashMap<String, String>::iterator it = allowedHosts.find(host);
> > +    if (it != allowedHosts.end())
> > +        it->value = String();
> > +    else
> > +        allowedHosts.add(host, String());
> 
> This should be written like this:
> 
>     allowedHosts.set(host, String());
> 
> It doesn’t require multiple lines of code.

Yes, you are right, thanks. I paid attention to it in Bug124569.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list