[Webkit-unassigned] [Bug 124569] [curl] Improve ssl certificate storage and check

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124569





--- Comment #2 from sipka at inf.u-szeged.hu  2013-11-21 01:47:39 PST ---
(In reply to comment #1)
> (From update of attachment 217277 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217277&action=review
> 
Thanks for the detailed review. 

> Looks good overall.  I have some concern about the BIO_get_mem_data call (though I realize this wasn't code you added).  Can you review and let me know what you think?
> 
BIO_get_mem_data() sets pp to a pointer to the start of the memory BIOs data and returns the total amount of data available. 
length = BIO_get_mem_data(bio, &certificateData);
// here - certificateData is a pointer to encoded data, length - length of data.

> > Source/WebCore/platform/network/curl/SSLHandle.cpp:146
> > +        unsigned char *certificateData;
> 
> unsigned char* certificateData;
>
I changed this. 

> > Source/WebCore/platform/network/curl/SSLHandle.cpp:147
> > +        long len = BIO_get_mem_data(bio, &certificateData);
> 
> The BIO_get_mem_data documentation is pretty weak.  Does it ever return a negative value?  If not, why is the return value signed?  If it is negative, then the following code will do bad things.
Yes, I made the change what is necessary to avoid unexpected behaviors in Bug119436 which this bug depends on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.