[Webkit-unassigned] [Bug 105784] Remove ENABLE_WORKERS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105784


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217293|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #22 from Benjamin Poulain <benjamin at webkit.org>  2013-11-20 22:31:24 PST ---
(From update of attachment 217293)
View in context: https://bugs.webkit.org/attachment.cgi?id=217293&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests, covered by existing tests.
> +

Remove this line, this is not necessary.

Please also remove the giant list of file, that is useless.

> Source/WebCore/WebCore.exp.in:-2884
> -#if ENABLE(WORKERS)
>  __ZN7WebCore12WorkerThread17workerThreadCountEv
> -#endif

You should put this export in the main list now.

> Source/WebCore/bindings/generic/ActiveDOMCallback.cpp:-39
> -#if ENABLE(WORKERS)
>  #include "WorkerGlobalScope.h"
> -#endif

Please move the include in the #include list.

> Source/WebCore/bindings/js/ScriptState.cpp:46
>  #include "JSWorkerGlobalScope.h"

This include should go in the list now.

> Source/WebCore/inspector/CodeGeneratorInspector.py:204
> +

???

> Source/WebCore/inspector/InspectorWorkerAgent.cpp:158
>  void InspectorWorkerAgent::canInspectWorkers(ErrorString*, bool* result)
>  {
> -#if ENABLE(WORKERS)
>      *result = true;
> -#else
> -    *result = false;
> -#endif
>  }

Remove this function instead and clean the call sites.

> Source/WebCore/loader/WorkerThreadableLoader.h:-35
> -
> -#if ENABLE(WORKERS)
> -

Add a blank line between #define WorkerThreadableLoader_h and the first #include.

> Source/WebCore/page/WorkerNavigator.h:-30
> -
> -#if ENABLE(WORKERS)
> -

Blank line here.

> Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:-443
> -#if ENABLE(WORKERS)
>          ?workerThreadCount at WorkerThread@WebCore@@SAIXZ
> -#endif

This probably needs to be moved in the main section, sorted alphabetically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.