[Webkit-unassigned] [Bug 124474] [EFL] Implement download directory selector on Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124474





--- Comment #7 from Jongwoo Choi <jw0330.choi at samsung.com>  2013-11-20 20:38:38 PST ---
(In reply to comment #5)
> (From update of attachment 217494 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217494&action=review
> 
> > Tools/MiniBrowser/efl/main.c:679
> > +    elm_fileselector_expandable_set(directory_selector, EINA_FALSE);
> 
> If I remember correctly, we don't need this because default value is EINA_FALSE.

After built with exclude elm_fileselector_expandable_set(directory_selector, EINA_FALSE); line, directory selector set to tree view. I think that default value is EINA_TRUE.

> 
> > Tools/MiniBrowser/efl/main.c:680
> > +    elm_fileselector_buttons_ok_cancel_set(directory_selector, EINA_FALSE);
> 
> Do you have any reason to use custom ok / cancel instead of builtin ?

Maybe I didn't have fully knowledge about smartcallback when i first made this code.
Now, I understand this part and fixed it using built-in ok/cancel button.
To use built-in button, on_download_request() was changed to on_directoryselector_done() function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.