[Webkit-unassigned] [Bug 124474] [EFL] Implement download directory selector on Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124474





--- Comment #6 from Jongwoo Choi <jw0330.choi at samsung.com>  2013-11-20 16:52:34 PST ---
(In reply to comment #3)
> (From update of attachment 217166 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217166&action=review
> 
> Currently, MiniBrowser doesn't work on my environment. Let me review this patch further after fixing my problem.
> 
> > Tools/MiniBrowser/efl/main.c:615
> > +    evas_object_event_callback_del(ds_data->parent->elm_window, EVAS_CALLBACK_DEL, on_directorypicker_parent_deletion);
> 
> Should we deregister this callback here ? If not, we can add close_director_picker() as close_file_picker(), then I think it is better to reuse the same function instead of duplicating code.
> 
> > Tools/MiniBrowser/efl/main.c:644
> > +    ecore_main_loop_quit();
> 
> Why should we finish download job in on_download_progress though there is on_download_finished ?

I made close_directory_picker() similar to close_file_picker() and merged these two codes to reuse same function.

To avoid duplication, I moved deregister callback and ecore_main_loop_quit() from on_directorypicker_deletion() and on_download_progress() to close_directory_picker().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.