[Webkit-unassigned] [Bug 124671] [GTK] Cannot scroll in option menu when it larger than the screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124671





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-20 11:13:55 PST ---
(In reply to comment #2)
> (From update of attachment 217458 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217458&action=review
> 
> > Source/WebCore/platform/gtk/GtkPopupMenu.cpp:95
> > +        for (i = 0, child = children.get(); i < itemCount; i++, child = g_list_next(child)) {
> 
> I think that if you declare i and child here they will be scoped properly. For instance:
> 
> for (int i = 0, GList* child = children.get();...

Yes, that would be really great, but it doesn't work :-(

> > Source/WebCore/platform/gtk/GtkPopupMenu.cpp:114
> > +    guint button = event && event->type == GDK_BUTTON_PRESS ? event->button.button : 1;
> > +    guint32 activateTime = event ? gdk_event_get_time(event) : GDK_CURRENT_TIME;
> 
> Nice cleanup.

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.