[Webkit-unassigned] [Bug 124671] [GTK] Cannot scroll in option menu when it larger than the screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124671





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-11-20 11:05:07 PST ---
(From update of attachment 217458)
View in context: https://bugs.webkit.org/attachment.cgi?id=217458&action=review

> Source/WebCore/platform/gtk/GtkPopupMenu.cpp:95
> +        for (i = 0, child = children.get(); i < itemCount; i++, child = g_list_next(child)) {

I think that if you declare i and child here they will be scoped properly. For instance:

for (int i = 0, GList* child = children.get();...

> Source/WebCore/platform/gtk/GtkPopupMenu.cpp:114
> +    guint button = event && event->type == GDK_BUTTON_PRESS ? event->button.button : 1;
> +    guint32 activateTime = event ? gdk_event_get_time(event) : GDK_CURRENT_TIME;

Nice cleanup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.