[Webkit-unassigned] [Bug 124654] [GStreamer] GStreamerVersioning's funtion utility setGstBufferSize casts from signed values to unsigned without checking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124654


Andres Gomez Garcia <agomez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |124534




--- Comment #3 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-20 09:45:58 PST ---
(In reply to comment #2)
> (From update of attachment 217428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217428&action=review
> 
> setGstBufferSize will be going away once the GStreamer 0.10 code is removed. It might be better to re-evaluate your patch then.

Blocking with bug 124534 , then.

> > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:166
> > +    ASSERT((static_cast<gint64>(G_MINSSIZE) > newSize)
> > +        || (static_cast<gint64>(G_MAXSSIZE) < newSize));
> 
> This should be one line.

Just to know for further patches. I was just following the recommendation in the point 5. of the "Indentation" section at:
http://www.webkit.org/coding/coding-style.html

Then, which is the maximum line length or when it is OK to write a sentence in more than one line?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.