[Webkit-unassigned] [Bug 124654] [GStreamer] GStreamerVersioning's funtion utility setGstBufferSize casts from signed values to unsigned without checking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124654





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-11-20 08:41:29 PST ---
(From update of attachment 217428)
View in context: https://bugs.webkit.org/attachment.cgi?id=217428&action=review

setGstBufferSize will be going away once the GStreamer 0.10 code is removed. It might be better to re-evaluate your patch then.

> Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:166
> +    ASSERT((static_cast<gint64>(G_MINSSIZE) > newSize)
> +        || (static_cast<gint64>(G_MAXSSIZE) < newSize));

This should be one line.

> Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:171
> +    ASSERT((0 > newSize)
> +        || (static_cast<gint64>(G_MAXUINT) < newSize));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.