[Webkit-unassigned] [Bug 124650] Move stray urls into common.config.urls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124650


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217414|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2013-11-20 05:46:24 PST ---
(From update of attachment 217414)
View in context: https://bugs.webkit.org/attachment.cgi?id=217414&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:38
> +import webkitpy.common.config.urls as config_urls

We don't use this style of import in webkitpy.
Please import svn_server_host and svn_server_realm separately using "from ~ import ~" below.

> Tools/Scripts/webkitpy/common/net/statusserver.py:36
> +import webkitpy.common.config.urls as config_urls

Ditto.

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:-40
> +import webkitpy.common.config.urls as config_urls
>  
>  from webkitpy.common import find_files
>  from webkitpy.common.checkout.scm.detection import SCMDetector
> -from webkitpy.common.config.urls import view_source_url

This is just a bad change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.