[Webkit-unassigned] [Bug 124474] [EFL] Implement download directory selector on Minibrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 02:22:06 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124474





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-11-20 02:20:39 PST ---
(From update of attachment 217166)
View in context: https://bugs.webkit.org/attachment.cgi?id=217166&action=review

Currently, MiniBrowser doesn't work on my environment. Let me review this patch further after fixing my problem.

> Tools/MiniBrowser/efl/main.c:615
> +    evas_object_event_callback_del(ds_data->parent->elm_window, EVAS_CALLBACK_DEL, on_directorypicker_parent_deletion);

Should we deregister this callback here ? If not, we can add close_director_picker() as close_file_picker(), then I think it is better to reuse the same function instead of duplicating code.

> Tools/MiniBrowser/efl/main.c:644
> +    ecore_main_loop_quit();

Why should we finish download job in on_download_progress though there is on_download_finished ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list