[Webkit-unassigned] [Bug 124579] Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124579





--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2013-11-19 10:16:29 PST ---
(From update of attachment 217297)
View in context: https://bugs.webkit.org/attachment.cgi?id=217297&action=review

To fix the build, please update WebCore.exp. There is no need to change WebCore.order, even if it gets out of date - it's generated from profile data when needed.

But I think that this patch doesn't fix all the code paths where an implicit cast occurs.

> Source/WebCore/loader/ResourceLoader.cpp:193
> -void ResourceLoader::addDataOrBuffer(const char* data, int length, SharedBuffer* buffer, DataPayloadType dataPayloadType)
> +void ResourceLoader::addDataOrBuffer(const char* data, size_t length, SharedBuffer* buffer, DataPayloadType dataPayloadType)

The patch changes this function, but doesn't change call sites. Specifically, ResourceLoader::didReceiveDataOrBuffer still calls this function with an int length.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.