[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124325


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217162|review+, commit-queue+      |review-
               Flag|                            |




--- Comment #38 from Timothy Hatcher <timothy at apple.com>  2013-11-18 11:56:37 PST ---
(From update of attachment 217162)
View in context: https://bugs.webkit.org/attachment.cgi?id=217162&action=review

>> Source/WebCore/page/FrameSnapshotting.cpp:86
>> +    float deviceScaleFactor = frame.page() ? 1 : frame.page()->deviceScaleFactor();
> 
> Is this backwards? I would expect that If there is a page this should be the page's deviceScaleFactor, otherwise 1.

Yes, the old code was:

    float deviceScaleFactor = 1;
    if (m_page)
        deviceScaleFactor = m_page->deviceScaleFactor();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.