[Webkit-unassigned] [Bug 123015] [GStreamer] webkitwebaudiosrc element needs to emit stream-start, caps and segment events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123015





--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net>  2013-11-18 09:53:10 PST ---
(From update of attachment 216550)
View in context: https://bugs.webkit.org/attachment.cgi?id=216550&action=review

Looks good overall IMHO

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:213
> +    gst_segment_init(priv->segment, GST_FORMAT_TIME);

You can directly store the segment in the WebKitWebAudioSourcePrivate. No need for another allocation

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.