[Webkit-unassigned] [Bug 124404] [AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124404





--- Comment #4 from Krzysztof Czech <k.czech at samsung.com>  2013-11-18 08:23:34 PST ---
(In reply to comment #3)
> (From update of attachment 217040 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.h:-64
> > -    AXComputedObjectAttributeCache() { }
> > -
> 
> Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :)

I'm thinking about any benefits of moving to public and declaring AXComputedObjectAttributeCache() { } as a explicit. I guess there won't be any implicit conversions. It's a constructor without parameters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.