[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124325





--- Comment #32 from Brian Burg <burg at cs.washington.edu>  2013-11-17 15:35:31 PST ---
(In reply to comment #27)

> > Source/WebCore/page/FrameSnapshotting.h:44
> > +enum {
> > +    SnapshotOptionsExcludeSelectionHighlighting = 1 << 1,
> > +    SnapshotOptionsInViewCoordinates = 1 << 2,
> > +    SnapshotOptionsForceBlackText = 1 << 3,
> > +};
> > +typedef uint32_t SnapshotOptions;
> 
> This is C++, so this should probably use enum SnapshotOptions { ... } instead of the typedef.

I made the other changes but not this one.

Since these are not mutually exclusive options, I did the same thing as elsewhere for this circumstance (i.e. WebKit2/shared/ImageOptions.h). Making the values strongly-typed prevents masking out some options, such as forcing selection painting for snapshotSelection().

New win export symbols are coming when the bots catch up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.