[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124325


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217138|review?                     |review+
               Flag|                            |




--- Comment #27 from Sam Weinig <sam at webkit.org>  2013-11-17 12:12:10 PST ---
(From update of attachment 217138)
View in context: https://bugs.webkit.org/attachment.cgi?id=217138&action=review

Overall, looks great. r=me with the changes.

> Source/WebCore/page/FrameSnapshotting.h:44
> +enum {
> +    SnapshotOptionsExcludeSelectionHighlighting = 1 << 1,
> +    SnapshotOptionsInViewCoordinates = 1 << 2,
> +    SnapshotOptionsForceBlackText = 1 << 3,
> +};
> +typedef uint32_t SnapshotOptions;

This is C++, so this should probably use enum SnapshotOptions { ... } instead of the typedef.

> Source/WebCore/page/FrameSnapshotting.h:47
> +OwnPtr<ImageBuffer> snapshotNode(Frame&, Node*);

This should take the Node by reference.

> Source/WebCore/page/FrameSnapshotting.h:48
> +OwnPtr<ImageBuffer> snapshotFrameRect(Frame&, const IntRect&, SnapshotOptions = 0);
> +OwnPtr<ImageBuffer> snapshotNode(Frame&, Node*);
> +OwnPtr<ImageBuffer> snapshotSelection(Frame&, SnapshotOptions = 0);

These should return std::unique_ptr<ImageBuffer>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.