[Webkit-unassigned] [Bug 124153] [EFL] Fix several warnings for ARM cross compilation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 16 02:34:49 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124153





--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-11-16 02:33:25 PST ---
(From update of attachment 217042)
View in context: https://bugs.webkit.org/attachment.cgi?id=217042&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [EFL] Fix several warnings for ARM cross compilation

I think your patch doesn't only deal with EFL port area. So, it looks it would be better to split this patch into two patches, one is for WebCore and JS and WK2, other one is for only EFL. Anyway, current patch is not only for EFL port. So, [EFL] prefix is not proper for this patch.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:965
> +    UNUSED_PARAM(pc);

BTW, isn't the *pc* argument being used below line ?

http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp#L987

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list