[Webkit-unassigned] [Bug 124365] REGRESSION(r159276): Lots of crashes for ARM builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 14 15:23:34 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124365





--- Comment #6 from Julien Brianceau <jbriance at cisco.com>  2013-11-14 15:22:13 PST ---
(In reply to comment #2)
> > Source/JavaScriptCore/offlineasm/arm.rb:465
> > +                $asm.puts "pop {r4-r6, r8-r12}"                
> 
> Since r12 is a global scratch, why do we need to save it?
> 
> > Source/JavaScriptCore/offlineasm/arm.rb:471
> > +                $asm.puts "push {r4-r6, r8-r12}"
> 
> Ditto.

You're right, that was not necessary. Thanks for the review & having landed it!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list