[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124325





--- Comment #15 from Brian Burg <burg at cs.washington.edu>  2013-11-14 10:29:49 PST ---
(In reply to comment #13)
> (From update of attachment 216943 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216943&action=review
> 
> >> Source/WebCore/bindings/objc/DOM.mm:292
> >> +    return [createDragImageForNode(*frame, node) autorelease];
> > 
> > You need to [[createDragImageForFrameSelection(…) retain] autorelease]. right now you are over releasing. I am surprised it worked before without a retain/autorelease.
> 
> I meant createDragImageForNode in this case, but this needs fixed everywhere you do create and autorelease.

Addressed these. Only the botched one in Clipboard.cpp was causing test crashes, so thanks for pointing it out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.