[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124325


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216943|review?                     |review-
               Flag|                            |




--- Comment #12 from Timothy Hatcher <timothy at apple.com>  2013-11-14 09:57:01 PST ---
(From update of attachment 216943)
View in context: https://bugs.webkit.org/attachment.cgi?id=216943&action=review

> Source/WebCore/bindings/objc/DOM.mm:292
> -    return frame->nodeImage(node).get();
> +    return [createDragImageForNode(*frame, node) autorelease];

You need to [[createDragImageForFrameSelection(…) retain] autorelease]. right now you are over releasing. I am surprised it worked before without a retain/autorelease.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.