[Webkit-unassigned] [Bug 124322] [ASAN] WebKit2 fails to build with trunk clang: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:56:10: error: no matching conversion for C-style cast from 'RetainPtr<NSURLRequest>' to 'NSMutableURLRequest *'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124322





--- Comment #2 from David Farler <dfarler at apple.com>  2013-11-14 08:51:59 PST ---
This temporary requestToSerialize’s scope is limited to this function. Why not just make a mutable copy outright and have the declaration be RetainPtr<NSMutableURLRequest>?

Also,

if ([requestToSerialize HTTPBody] || [requestToSerialize HTTPBodyStream) {
    [requestToSerialize setHTTPBody:nil];
    [requestToSerialize setHTTPBodyStream:nil];
}

can be simplified to just

[requestToSerialize setHTTPBody:nil];
[requestToSerialize setHTTPBodyStream:nil];

All of this would workaround the clang problem and would also cut down the maximum number of objc message sends from this function from 5 to 3.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.