[Webkit-unassigned] [Bug 85994] [GStreamer] Source element fails with .ogg files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85994





--- Comment #40 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-14 07:55:05 PST ---
(In reply to comment #38)
> (From update of attachment 212178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212178&action=review
> 
> Looks like the patch is a step ahead but I miss some testing, we do not want to regress it in the future.
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:942
> > +    if (length > 0 && priv->requestedOffset && response.httpStatusCode() != 200)
> 
> I guess we should use == 206 here instead...
...

Done.

... 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1053
> > +        }
> 
> Not sure this is correct. AFAIK the server might return a valid range in the request even if it's smaller than the one we requested.
...

In a seek, requesting a Range, if we received a 200 response, this discards the data buffers from the beginning of the media file until the requested seek position. This code doesn't run on 206 PARTIAL_CONTENT responses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.