[Webkit-unassigned] [Bug 123568] AX: Children Nodes for Canvas objects are not equal to Render Objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123568





--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2013-11-14 06:50:32 PST ---
(From update of attachment 216926)
View in context: https://bugs.webkit.org/attachment.cgi?id=216926&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:416
> +#if  PLATFORM(EFL) ||  PLATFORM(GTK)

extra space after ||

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:419
> +#if  PLATFORM(EFL) ||  PLATFORM(GTK)
> +    if (m_node->isTextNode())
> +        return true;
> +#endif

Hmm... I don't think this is the best approach to skip text nodes from this point. It seems to me like it will be fine for this very specific case but it might fail for some others that are also platform specific.

What about trying to do something similar to what it's done in AccessibilityRenderObject::computeAccessibilityIsIgnored(), so we check first whether the defaultObjectInclusion() function (which also checks platform specific stuff) to see if we can know in advance whether we should be ignoring things?

I mean, something like this:

bool AccessibilityNodeObject::computeAccessibilityIsIgnored() const
{
#ifndef NDEBUG
    // Double-check that an AccessibilityObject is never accessed before
    // it's been initialized.
    ASSERT(m_initialized);
#endif

    AccessibilityObjectInclusion decision = defaultObjectInclusion();
    if (decision == IncludeObject)
        return false;
    if (decision == IgnoreObject)
        return true;

    // If this element is within a parent that cannot have children, it should not be exposed.
    if (isDescendantOfBarrenParent())
        return true;

    return m_role == UnknownRole;
}

Would that work OK?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.