[Webkit-unassigned] [Bug 119436] [curl] Improve detecting and handling of SSL related errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119436





--- Comment #23 from Brent Fulgham <bfulgham at webkit.org>  2013-11-13 09:18:40 PST ---
(In reply to comment #22)
> (From update of attachment 216791 [details])
> > Source/WebCore/platform/network/curl/SSLHandle.cpp:150
> > +    SSL* ssl = (SSL*)X509_STORE_CTX_get_ex_data(ctx, SSL_get_ex_data_X509_STORE_CTX_idx());
> 
> This should be a C++-style cast (prob. a reinterpret_cast<SSL*>)

I didn't do an exhaustive check for C-style casts, so please double-check that all of your casting is done using C++ style.  Sometimes this (annoyingly) requires you to chain a couple of casts together, but it's still preferred so that it's explicit what type conversions you are doing.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.