[Webkit-unassigned] [Bug 124199] Fixed unused parameter warnings in WebCore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 13 02:19:44 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=124199
Csaba Osztrogonac <ossy at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #216691|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #10 from Csaba Osztrogonac <ossy at webkit.org> 2013-11-13 02:18:23 PST ---
(From update of attachment 216691)
View in context: https://bugs.webkit.org/attachment.cgi?id=216691&action=review
LGTM in general, but r- now due to style issues, please fix them.
> Source/WebCore/css/CSSCursorImageValue.cpp:178
> +#else
> + UNUSED_PARAM(document);
wrong indentation here too
> Source/WebCore/dom/Document.cpp:4874
> +#else
> + UNUSED_PARAM(isThrottled);
ditto
> Source/WebCore/loader/DocumentThreadableLoader.cpp:335
> + UNUSED_PARAM(identifier);
ditto
> Source/WebCore/loader/DocumentThreadableLoader.cpp:361
> + UNUSED_PARAM(identifier);
ditto
> Source/WebCore/rendering/style/RenderStyle.cpp:793
> + UNUSED_PARAM(other);
ditto
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list