[Webkit-unassigned] [Bug 122448] [ATK] Support compilation of EFL/GTK without accessibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122448





--- Comment #9 from Krzysztof Czech <k.czech at samsung.com>  2013-11-12 05:27:30 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434
> > > > > +namespace WTR {
> > > > 
> > > > Is there code like this already inside AccessibilityUIElement.cpp?
> > > Yes there is, you mean it could be reused ?.
> > > Sounds good, I will check this.
> > 
> > It could be reused as well as I guess bits from AccessibilityUIController.cpp
> > Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp
> > can be changed to 
> > #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY)
> > 
> > but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen.
> 
> I think we should re-use these. I don't want to have to maintain two long lists of unsupported functions when adding to DRT

Yes, you are right in terms of maintenance, this would not be a good idea to support it. Thanks for the suggestion. I already prepared a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.