[Webkit-unassigned] [Bug 123015] [GStreamer] webkitwebaudiosrc element needs to emit stream-start, caps and segment events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123015





--- Comment #9 from Philippe Normand <pnormand at igalia.com>  2013-11-11 00:51:31 PST ---
(In reply to comment #7)
> (From update of attachment 215393 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215393&action=review
> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:402
> > +            gchar* queueName = gst_element_get_name(queue);
> 
> Maybe you can use GOwnPtr here?
> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:403
> > +            gchar* stream_id = g_strdup_printf("webaudio/%s", queueName);
> 
> Ditto.

That was a WiP patch, not really worth a review, but yes it had a comment about using smart pointers :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.