[Webkit-unassigned] [Bug 124043] [GTK] Crash when printing via javascript in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124043





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-10 01:20:56 PST ---
(In reply to comment #6)
> > This is not possible, at this point data contains a NULL pointer, because of the leakPtr(). That's why we first need to save the pointer.
> 
> 
> Good point. How about this: 
> 
> // Make sure the print pages idle has more priority than IPC messages comming from
> // the IO thread, so that the EndPrinting message is always handled once the print
> // operation has finished. See https://bugs.webkit.org/show_bug.cgi?id=122801.
> unsigned idlePriority = m_printMode == PrintInfo::PrintModeSync ? G_PRIORITY_DEFAULT - 10 : G_PRIORITY_DEFAULT_IDLE + 10;
> GMainLoop* mainLoop = data->mainLoop;

GMainLoop* mainLoop = data->mainLoop.get(); :-)

> m_printPagesIdleId = gdk_threads_add_idle_full(idlePriority, printPagesIdle, data.leakPtr(), printPagesIdleDone);
> 
> if (m_printMode == PrintInfo::PrintModeSync) {
>     ASSERT(mainLoop);
>     g_main_loop_run(mainLoop);
> }

Ok, looks good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.