[Webkit-unassigned] [Bug 123879] Ended event should be triggered also when playback rate is negative

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 09:12:54 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=123879





--- Comment #32 from Eric Carlson <eric.carlson at apple.com>  2013-11-08 09:11:39 PST ---
(In reply to comment #21)
> (In reply to comment #19)
> > (From update of attachment 216278 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=216278&action=review
> > 
> > > LayoutTests/media/video-ended-event-negative-playback.html:22
> > > +        <video loop/>
> > 
> > I wonder if the failure on the Mac is because of this: a video element is not a void element, it must have an end tag
> > 
> > > Source/WebCore/html/HTMLMediaElement.cpp:3679
> > >      double dur = duration();
> > 
> > As before, can you please get rid of the "dur" abbreviation while you are here: 
> > 
> > double duration = this->duration();
> 
> I cannot change 'dur' to 'duration' because then i would get compiler error. Var name cannot override function name used in same scope.

Really? Did you actually try my suggestion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list