[Webkit-unassigned] [Bug 50619] [GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50619





--- Comment #55 from Martin Robinson <mrobinson at webkit.org>  2013-11-06 11:41:26 PST ---
(In reply to comment #54)
> (From update of attachment 216051 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216051&action=review
>
> > bool hasVerticalGlyphs = glyphExtents.x_advance;
> > 
> > This will allow you to remove the comment too.
> 
> Unfortunately there are corner cases where cairo_scaled_font_glyph_extents() returns x_advance with values like 3.0e-16 instead of zero, and they aren't converted into zero without casting.
> To void this problem, I will use y_advance instead, which has not shown this problem.

Yikes! Interesting problem. Even if you use y_advance it might be good to make the test something like 

bool hasVerticalGlyphs = glyphExtents.x_advance > epsilon;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.