[Webkit-unassigned] [Bug 123899] [GTK] Use deprecation guards around deprecated API in GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123899





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-06 09:58:04 PST ---
(In reply to comment #2)
> (From update of attachment 216185 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review
> 
> Looking good, with one small nit about the comment style.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009
> > +        push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");
> 
> See below.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234
> > +        push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");
> 
> See below.
> 
> > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167
> > +#endif /* WEBKIT_DISABLE_DEPRECATED */
> 
> I think we typically use C++ style comments for this sort of thing.

Yes, that's what I thought, but I checked the feature guards and they all use /* */.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.