[Webkit-unassigned] [Bug 123885] AX: [ATK] <span> elements exposed through ATK when not needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 09:52:37 PST 2013


--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2013-11-06 09:51:23 PST ---
(From update of attachment 216177)
View in context: https://bugs.webkit.org/attachment.cgi?id=216177&action=review

>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1925
>> +
> can all these checks move into AccessibilityObject?

Hmm... yes and no: we can move the MathML part but not the ariaAccessibilityDescription() call since that's a non-virtual method from AccessibilityNodeObject.

>> Source/WebCore/accessibility/AccessibilityObject.h:608
>> +    virtual bool hasAccessibleName() const;
> I think this should be called something like hasAccessibleAttributes() or hasRequiredInclusionAttributes() or hasAttributedRequiredForInclusion()
> something to denote that this method should be used to determine whether to include it in the tree

Believe it or not, I struggled to find a name for this and in the end this is the least bad I found.

hasAttributedRequiredForInclusion() sounds good to me, though

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list