[Webkit-unassigned] [Bug 99825] [ATK] accessibility/title-ui-element-correctness.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99825





--- Comment #5 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2013-11-06 05:45:56 PST ---
(From update of attachment 216163)
View in context: https://bugs.webkit.org/attachment.cgi?id=216163&action=review

>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:194
>> +static void removeAtkRelationFromRelationSetByType(AtkRelationSet* relationSet, AtkRelationType relationType)
> 
> I think removeAtkRelationByType is enough for the name

OK

>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:199
>> +        if (atk_relation_get_relation_type(relation) == ATK_RELATION_LABELLED_BY) {
> 
> You should be comparing against your relationType parameter, not that hardcoded case

my bad, I will fix it

>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:201
>> +            break;
> 
> You should not break here, as the same type of AtkRelation might exist between one base object and one or more target objects. So, if you are removing by type you should remove them all the relationships matching that type

I am not sure about it. In atk_relation_set_add_relation_by_type, there is a check if relation of that type is present in relation set. If yes, a new target is added, but no new relation is added to relation set - so I assume there should be only one relation of given type in relation set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.