[Webkit-unassigned] [Bug 99825] [ATK] accessibility/title-ui-element-correctness.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99825


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216163|review?                     |review-
               Flag|                            |




--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2013-11-06 05:17:30 PST ---
(From update of attachment 216163)
View in context: https://bugs.webkit.org/attachment.cgi?id=216163&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:194
> +static void removeAtkRelationFromRelationSetByType(AtkRelationSet* relationSet, AtkRelationType relationType)

I think removeAtkRelationByType is enough for the name

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:199
> +        if (atk_relation_get_relation_type(relation) == ATK_RELATION_LABELLED_BY) {

You should be comparing against your relationType parameter, not that hardcoded case

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:201
> +            break;

You should not break here, as the same type of AtkRelation might exist between one base object and one or more target objects. So, if you are removing by type you should remove them all the relationships matching that type

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.