[Webkit-unassigned] [Bug 123791] [GStreamer] Playback rate is ommitted when seeking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123791





--- Comment #9 from Philippe Normand <pnormand at igalia.com>  2013-11-05 07:31:56 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 216019 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=216019&action=review
> > 
> > Looks good but I have some nits about the test. Can you please fix them?
> > 
> > > LayoutTests/media/video-seek-with-negative-playback.html:1
> > > +<video></video>
> > 
> > <video/>
> > It'd be good to make this a normal html file with the usual head and body too.
> 
> The problem is that when i use html, head, and body tags test would look much more complicated becouse of needed getElementById calls, etc.
> 

Come on, it's not that complicated. There's also a findMediaElement() function...

> > 
> > > LayoutTests/media/video-seek-with-negative-playback.html:8
> > > +        function ()
> > 
> > The coding style is not very consistent about curly braces. Can the test be refactored to avoid the nested waitForEvent()s?
> 
> The problem is that we have to wait for seeked event to listen for timeupdate event. Also we can't seek if player is not ready to play.
> 

Fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.