[Webkit-unassigned] [Bug 123663] [GTK] Missing symbols in 2.3.1, ABI break?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123663


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215881|review?                     |review-
               Flag|                            |




--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-05 01:55:29 PST ---
(From update of attachment 215881)
View in context: https://bugs.webkit.org/attachment.cgi?id=215881&action=review

Please make sure the patch applies in current git master.

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:563
> +// WebKitDOMHTMLElement

This should be WebKitDOMHTMLHeadElement

> Source/WebCore/bindings/gobject/WebKitDOMCustom.h:478
> + * Returns:

Add something after the Returns: tag to avoid a warning when generating docs. It could be just Returns: a #gchar

> Source/WebCore/bindings/gobject/WebKitDOMCustom.h:481
> +WEBKIT_API gchar* webkit_dom_html_head_element_get_profile(void* self);

Use WebKitDOMHTMLHeadElement* instead of void*. We use only void* when the whole class has been removed from the API.

> Source/WebCore/bindings/gobject/WebKitDOMCustom.h:493
> + * Returns:
> + *
> +**/
> +WEBKIT_API void webkit_dom_html_head_element_set_profile(void* self, const gchar* value);

Same comments here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.