[Webkit-unassigned] [Bug 116315] DFG_OPERATIONs with double arguments generate incorrect code on ARM soft-fp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 10:51:04 PST 2013


--- Comment #3 from Csaba Osztrogonac <ossy at webkit.org>  2013-11-04 10:49:51 PST ---
(From update of attachment 202085)
View in context: https://bugs.webkit.org/attachment.cgi?id=202085&action=review

>> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:580
>>  #endif // CPU(ARM_HARDFP)
> I'm no expert, but is this the #define for ARM_HARDFP? Why are we assuming the softfp ABI inside of this #define?

This #endif comment is very very misleading, because 
it is the end of the _else_ case of CPU(ARM_HARDFP). 

(Otherwise this file is moved to Source/JavaScriptCore/jit/CCallHelpers.h.)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list