[Webkit-unassigned] [Bug 123439] Fix reported build warnings for GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123439





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-11-04 09:39:49 PST ---
(From update of attachment 215916)
View in context: https://bugs.webkit.org/attachment.cgi?id=215916&action=review

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:-70
> -gchar* webkit_dom_html_element_get_id(WebKitDOMHTMLElement* element)
> -{
> -    g_warning("The get_id method on WebKitDOMHTMLElement is deprecated. Use the one in WebKitDOMElement instead.");
> -    return webkit_dom_element_get_id(WEBKIT_DOM_ELEMENT(element));

I think removing these methods will cause an ABI break, which is why they were added in the first place.

> Source/WebCore/bindings/gobject/WebKitDOMEventTarget.cpp:77
> +/*gboolean webkit_dom_event_target_add_event_listener_with_closure(WebKitDOMEventTarget* target, const char* eventName, GClosure* handler, gboolean useCapture)

Why is this commented out?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1618
> -    gdk_threads_leave();
>      g_main_loop_run(webView->priv->modalLoop.get());
> -    gdk_threads_enter();
>  }

I'm not sure if it's right to remove this here. I think we need to keep it to avoid breaking applications (even though the functions are deprecated).

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:-103
> -    gdk_threads_leave();
>      g_main_loop_run(m_runLoop.get());
> -    gdk_threads_enter();
> -

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.