[Webkit-unassigned] [Bug 112015] [EFL] accessibility/textarea-line-for-index.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 07:03:35 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=112015





--- Comment #6 from Rob Płóciennik <r.plociennik at samsung.com>  2013-11-04 07:02:21 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Also, you probably want to check index >= atk_text_get_character_count(ATK_TEXT(m_element)) here (opposite to just >)
> > 
> > If I understand correctly, the index equal to the string's length corresponds 
> > to a situation where the caret is placed right after the last character. 
> > Wouldn't that cause additional failures in cases where the string in question 
> > ended with a newline?
> 
> I'm not sure I understand what you mean? What kind of failures are you considering? Do you have an specific example/failing test case that we can use to discuss about this?

Let's consider a test string of "\n". Wouldn't a valid index range in this case be [0,1], with 0 corresponding to a caret placed just before the newline and 1 right after it, resulting in returned line numbers of 0 and 1 respectively? If so, shouldn't the index validity check accept ranges up to and including the length of the input string?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list