[Webkit-unassigned] [Bug 123635] Move CF/Mac WTF String implementations down into WTF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123635





--- Comment #5 from WebKit Commit Bot <commit-queue at webkit.org>  2013-11-01 17:35:32 PST ---
Attachment 215785 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/text/cf/AtomicStringCF.cpp', u'Source/WTF/wtf/text/cf/StringCF.cpp', u'Source/WTF/wtf/text/cf/StringImplCF.cpp', u'Source/WTF/wtf/text/mac/StringImplMac.mm', u'Source/WTF/wtf/text/mac/StringMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/text/cf/AtomicStringCF.cpp', u'Source/WebCore/platform/text/cf/StringCF.cpp', u'Source/WebCore/platform/text/cf/StringImplCF.cpp', u'Source/WebCore/platform/text/mac/StringImplMac.mm', u'Source/WebCore/platform/text/mac/StringMac.mm']" exit_code: 1
Source/WTF/wtf/text/WTFString.h:412:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/WTF/wtf/text/cf/StringCF.cpp:37:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WTF/wtf/text/cf/StringImplCF.cpp:49:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.