[Webkit-unassigned] [Bug 121079] structure of frame tree is not correct in WINCE port.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121079





--- Comment #12 from Patrick R. Gansterer <paroga at paroga.com>  2013-11-01 03:33:51 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 215704 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=215704&action=review
> > 
> > > Source/WebKit/wince/WebView.cpp:161
> > > +    Frame* parentFrame = frame;
> > 
> > Why do this additional assignment? Just rename the parameter name of the function.
> > 
> > Otherwise looks ok to me.
> I changed the name because I think parentFrame is a suitable name for this variable. Anyway I will change it back and upload a new patch.

Renaming it to parentFrame is ok, but the assignment of "parentFrame = frame" is not necessary. Just rename frame (last parameter of the method) to parentFrame.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.