[Webkit-unassigned] [Bug 124731] check-webkit-style is wrong about expected format parameter pack rvalue reference arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124731





--- Comment #10 from László Langó <lango at inf.u-szeged.hu>  2013-11-28 23:14:25 PST ---
(In reply to comment #9)
> (From update of attachment 217663 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217663&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/cpp.py:1848
> >      if matched:
> > -        error(line_number, 'whitespace/operators', 3,
> > -              'Missing spaces around %s' % matched.group(1))
> > +        # It is necessary to check this because rvaule references
> > +        # parameter packs (c++11 feature)
> > +        if not search(r'&&\.\.\.', line):
> 
> These two ifs could be merged together.

You are right, we could simplify this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.