[Webkit-unassigned] [Bug 124937] Move PrettyPatch related code to prettypatch.py

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124937


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217992|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2013-11-28 05:39:54 PST ---
(From update of attachment 217992)
View in context: https://bugs.webkit.org/attachment.cgi?id=217992&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:200
> +        if self._port._pretty_patch.pretty_patch_available():
> +            pretty_patch = self._port._pretty_patch.pretty_patch_text(diff_filename)

We shouldn't be accessing port object's "private" variables like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.